Bladeren bron

chore: cleanup zRPC retry code (#1280)

Kevin Wan 3 jaren geleden
bovenliggende
commit
038491b7bc
2 gewijzigde bestanden met toevoegingen van 0 en 15 verwijderingen
  1. 0 1
      ROADMAP.md
  2. 0 14
      zrpc/client_test.go

+ 0 - 1
ROADMAP.md

@@ -16,7 +16,6 @@ We hope that the items listed below will inspire further engagement from the com
 - [x] Support `username/password` authentication in ETCD
 - [x] Support `SSL/TLS` in `zRPC`
 - [x] Support `TLS` in redis connections
-- [ ] Support `retry strategies` in `zRPC`
 
 ## 2022
 - [ ] Support `goctl mock` command to start a mocking server with given `.api` file

+ 0 - 14
zrpc/client_test.go

@@ -96,19 +96,6 @@ func TestDepositServer_Deposit(t *testing.T) {
 			return invoker(ctx, method, req, reply, cc, opts...)
 		}),
 	)
-	retryClient := MustNewClient(
-		RpcClientConf{
-			Endpoints: []string{"foo"},
-			App:       "foo",
-			Token:     "bar",
-			Timeout:   1000,
-		},
-		WithDialOption(grpc.WithContextDialer(dialer())),
-		WithUnaryClientInterceptor(func(ctx context.Context, method string, req, reply interface{},
-			cc *grpc.ClientConn, invoker grpc.UnaryInvoker, opts ...grpc.CallOption) error {
-			return invoker(ctx, method, req, reply, cc, opts...)
-		}),
-	)
 	tarConfClient := MustNewClient(
 		RpcClientConf{
 			Target:  "foo",
@@ -133,7 +120,6 @@ func TestDepositServer_Deposit(t *testing.T) {
 	clients := []Client{
 		directClient,
 		nonBlockClient,
-		retryClient,
 		tarConfClient,
 		targetClient,
 	}