Bläddra i källkod

add more tests

kevin 4 år sedan
förälder
incheckning
c9b0ac1ee4
3 ändrade filer med 11 tillägg och 4 borttagningar
  1. 4 4
      core/stores/kv/store.go
  2. 5 0
      core/stores/kv/store_test.go
  3. 2 0
      core/stores/redis/redis_test.go

+ 4 - 4
core/stores/kv/store.go

@@ -636,22 +636,22 @@ func (cs clusterStore) ZrevrangebyscoreWithScoresAndLimit(key string, start, sto
 	return node.ZrevrangebyscoreWithScoresAndLimit(key, start, stop, page, size)
 }
 
-func (cs clusterStore) Zscore(key string, value string) (int64, error) {
+func (cs clusterStore) Zrevrank(key, field string) (int64, error) {
 	node, err := cs.getRedis(key)
 	if err != nil {
 		return 0, err
 	}
 
-	return node.Zscore(key, value)
+	return node.Zrevrank(key, field)
 }
 
-func (cs clusterStore) Zrevrank(key, field string) (int64, error) {
+func (cs clusterStore) Zscore(key string, value string) (int64, error) {
 	node, err := cs.getRedis(key)
 	if err != nil {
 		return 0, err
 	}
 
-	return node.Zrevrank(key, field)
+	return node.Zscore(key, value)
 }
 
 func (cs clusterStore) getRedis(key string) (*redis.Redis, error) {

+ 5 - 0
core/stores/kv/store_test.go

@@ -516,6 +516,8 @@ func TestRedis_SortedSet(t *testing.T) {
 	assert.NotNil(t, err)
 	_, err = store.ZrevrangebyscoreWithScoresAndLimit("key", 5, 8, 1, 1)
 	assert.NotNil(t, err)
+	_, err = store.Zrevrank("key", "value")
+	assert.NotNil(t, err)
 	_, err = store.Zadds("key", redis.Pair{
 		Key:   "value2",
 		Score: 6,
@@ -640,6 +642,9 @@ func TestRedis_SortedSet(t *testing.T) {
 				Score: 5,
 			},
 		}, pairs)
+		rank, err = client.Zrevrank("key", "value1")
+		assert.Nil(t, err)
+		assert.Equal(t, int64(1), rank)
 		val, err = client.Zadds("key", redis.Pair{
 			Key:   "value2",
 			Score: 6,

+ 2 - 0
core/stores/redis/redis_test.go

@@ -713,6 +713,8 @@ func TestRedis_SortedSet(t *testing.T) {
 		pairs, err = client.ZrevrangebyscoreWithScoresAndLimit("key", 5, 8, 1, 0)
 		assert.Nil(t, err)
 		assert.Equal(t, 0, len(pairs))
+		_, err = NewRedis(client.Addr, "").Zrevrank("key", "value")
+		assert.NotNil(t, err)
 	})
 }